Administrative area bug fix #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribute. This fixes an issue where multiple search results would share the same list of administrative areas.
|
Good job! Maybe you have idea how to improve tests? Problems is that google is improving and updating geo data.. and tests have old data. |
|
Ideally tests shouldn't call google's services, because the data is subject to change. You might want to look into mocking the responses for different calls. For a brief intro to mock: http://www.toptal.com/python/an-introduction-to-mocking-in-python |
|
ok! Next good idea! :) I'll implement that solution in this week :) If you have some other ideas let me know! Maybe we can together create something really good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed administrative_area from a class attribute to an instance attribute. This fixes an issue where multiple search results would share the same list of administrative areas.
To see this bug, open up a python shell and search for two different places.